Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open both port 443 & 80 when AWS cert manager is in use. #221

Merged
merged 1 commit into from Jun 19, 2017
Merged

Open both port 443 & 80 when AWS cert manager is in use. #221

merged 1 commit into from Jun 19, 2017

Conversation

tamalsaha
Copy link
Contributor

cc: @julianvmodesto

Fixes #189

@tamalsaha tamalsaha requested a review from sadlil June 19, 2017 12:29
@tamalsaha tamalsaha added this to the 3.0.0 milestone Jun 19, 2017
@tamalsaha tamalsaha merged commit 38ca6cf into master Jun 19, 2017
@tamalsaha tamalsaha deleted the port branch June 19, 2017 12:31
@julianvmodesto
Copy link
Contributor

This works! But only when creating a new Ingress. Updating an existing Ingress with ingress.appscode.com/annotations-service: '{"service.beta.kubernetes.io/aws-load-balancer-ssl-cert": "..."}' doesn't seem to add port tcp-443.

@tamalsaha tamalsaha mentioned this pull request Jun 28, 2017
Closed
@tamalsaha
Copy link
Contributor Author

tamalsaha commented Jun 28, 2017 •
edited

Filed #267.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadlil sadlil Awaiting requested review from sadlil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tamalsaha @julianvmodesto